Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple platforms at once #1001

Closed
johanholmerin opened this issue Sep 15, 2023 · 2 comments · Fixed by #1002
Closed

Support multiple platforms at once #1001

johanholmerin opened this issue Sep 15, 2023 · 2 comments · Fixed by #1002

Comments

@johanholmerin
Copy link
Contributor

johanholmerin commented Sep 15, 2023

In some situations it might be useful to have binaries for different platforms downloaded at once. For example, when using docker on Mac it's common to use npm on directly on Mac but actually run the code in the docker linux vm, which will fail due to incompatible binaries. It's possible to download for binaries for another platform by running for example npm run install -- --update-binary --target_platform=linux --target_libc=glibc, but since bcrypt uses the same file path regardless of platform/architecture this will replace the existing binary. I propose changing module_path or module_name to include platform, arch, and libc, like the package_name currently does. I can submit a PR for this if you're interested.

Related issues:

@recrsn
Copy link
Collaborator

recrsn commented Sep 15, 2023

If its achievable, sure, go ahead.

@johanholmerin
Copy link
Contributor Author

Great, I've submitted a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants