Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The non-configurable node-pre-gyp's binary remote_path prevents from using bcrypt 1.0.3-3.0.0 off an enterprise artifactory #646

Closed
ilatypov opened this issue Aug 30, 2018 · 3 comments

Comments

@ilatypov
Copy link
Contributor

ilatypov commented Aug 30, 2018

  • What went wrong?
    Attempts to install bcrypt's pre-built binary from a local artifactory failed due to ignoring the subpath /artifactory/node-pre-gyp-binaries.
    npm install bcrypt@"^1.0.3" --bcrypt_lib_binary_host_mirror=https://INTERNAL_HOST/artifactory/node-pre-gyp-binaries

  • What did you expect to happen?
    The host mirror variable substitutes both the host name and the beginning of the path.

  • Which version of nodejs and OS?
    nodejs 8.9.4, Windows 7

@ilatypov
Copy link
Contributor Author

ilatypov commented Aug 30, 2018

Not starting "binary": { "remote_path": ... } with a forward slash works around erasing the subpath of the host mirror value due to using a url.resolve call in node-pre-gyp,

https://github.com/mapbox/node-pre-gyp/blob/master/lib/util/versioning.js

@ilatypov ilatypov changed the title The non-configurable node-pre-gyp's binary remote_path prevents from using bcrypt from an enterprise artifactory The non-configurable node-pre-gyp's binary remote_path prevented from using bcrypt 1.0.3 off an enterprise artifactory Aug 30, 2018
@ilatypov ilatypov reopened this Aug 30, 2018
@ilatypov ilatypov changed the title The non-configurable node-pre-gyp's binary remote_path prevented from using bcrypt 1.0.3 off an enterprise artifactory The non-configurable node-pre-gyp's binary remote_path prevented from using bcrypt 1.0.3-3.0.0 off an enterprise artifactory Aug 30, 2018
@ilatypov ilatypov changed the title The non-configurable node-pre-gyp's binary remote_path prevented from using bcrypt 1.0.3-3.0.0 off an enterprise artifactory The non-configurable node-pre-gyp's binary remote_path prevents from using bcrypt 1.0.3-3.0.0 off an enterprise artifactory Aug 30, 2018
@ilatypov
Copy link
Contributor Author

This is accidentally worked around for bcrypt releases past 3.0.0.

18efb66

@recrsn
Copy link
Collaborator

recrsn commented Aug 30, 2018

This is something I never took into consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants