Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial open source commit #1

Merged
merged 14 commits into from Nov 6, 2018
Merged

Conversation

t2oh4e
Copy link
Contributor

@t2oh4e t2oh4e commented Oct 5, 2018

No description provided.

@t2oh4e t2oh4e requested a review from kleinmann October 5, 2018 17:20
Copy link
Member

@kleinmann kleinmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some comments on wording and location of changes :-)

.gitlab-ci.yml.example Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
deploy-shopware.php Outdated Show resolved Hide resolved
deploy-shopware.php Outdated Show resolved Hide resolved
Copy link
Contributor Author

@t2oh4e t2oh4e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I covered all you comments. Please review again @kleinmann :)

README.md Outdated Show resolved Hide resolved
deploy.php Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@kleinmann kleinmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some additional comments based on your recent changes :-)

@kleinmann kleinmann merged commit 20571b0 into master Nov 6, 2018
@kleinmann kleinmann deleted the feature/open-source-deployer-config branch November 6, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants