Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the Bot.stop() function from failing when called explicitly within script #125

Merged
merged 4 commits into from Jan 31, 2023
Merged

Fixed the Bot.stop() function from failing when called explicitly within script #125

merged 4 commits into from Jan 31, 2023

Conversation

kelltom
Copy link
Owner

@kelltom kelltom commented Jan 31, 2023

Fixes OSR-38

@kelltom kelltom linked an issue Jan 31, 2023 that may be closed by this pull request
[OSR-38] Bot.stop() function does not work when called within script #124
Closed
@linear
Copy link

linear bot commented Jan 31, 2023

OSR-38 Bot.stop() function does not work when called within script

This is a bit of a weird bug. The stop() function is called from the UI's stop button, which correctly stops the bot. However, when you call this function within your script's code, it doesn't set the Bot Status on the UI.

The solution is to shuffle around the statement that sets the status to STOPPED.

@kelltom kelltom added the type: bug Something isn't working label Jan 31, 2023
@kelltom kelltom merged commit 45071e4 into main Jan 31, 2023
@kelltom kelltom deleted the 124-osr-38-botstop-function-does-not-work-when-called-within-script branch January 31, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OSR-38] Bot.stop() function does not work when called within script
1 participant
@kelltom