This plugin breaks other plugins that lint JSON

[EvgenyOrekhov]

eslint-plugin-json stops working (stops giving any warnings about *.json files) when I add json-files to my .eslintrc:

{
  "extends": ["plugin:json/recommended"],
  "plugins": ["json-files"]
}

If I remove "plugins": ["json-files"] from the above config, eslint-plugin-json starts working again.

[MichaelHettmer]

Try to explicitly add eslint-plugin-json to the plugins array. Did not test this, but in my understanding your plugins array with only "json-files" in it overwrites the plugins section of the default eslint-plugin-json config so it is not included and therefore never started.

{
  "extends": ["plugin:json/recommended"],
  "plugins": ["json", "json-files"]
}

[EvgenyOrekhov]

Just tried it. It doesn't help.

[barakyosi]

Any update on this issue?
I think this line breaks it:
https://github.com/kellyselden/eslint-plugin-json-files/blob/master/lib/processors/json.js#L25

Wonder if we can allow configuring it from outside, or add a better check there.

My current solution is to use patch-package to change this file 😕

[jerone]

I fixed this by using ESLint overrides:

{
  "root": true,
  "overrides": [
    /*
     * JSON files.
     */
    {
      "files": ["*.json"],
      "extends": [
        "plugin:json/recommended-with-comments"
      ]
    },

    /*
     * `package.json` file.
     * This needs it's own configuration, because it doesn't work together with `plugin:json`.
     * See https://github.com/kellyselden/eslint-plugin-json-files/issues/40
     */
    {
      "files": ["package.json"],
      "plugins": ["json-files"],
      "extends": [ ],
      "rules": {
        "json-files/rule-name": "error"
      }
    }
  ]
}

[a-c-m]

I am also hitting this. Using override trick didn't work for me, as I want to lint package.json specifically with the other module.

@barakyosi can you share what about /lib/processors/json.js#L25 that you are changing to fix it? and or submit a PR to fix it?

[steveszc]

I think this is happening because this plugin adds a (deprecated) file extension-based processor for all .json files, and the processor's postprocess method filters out any message where the ruleId is not prefixed with json-files/, so any other custom rules from other plugins will have a different ruleId prefix and those messages will be filtered out.

I can't find any way around this (other than patch-package), since there doesn't seem to be a way to override a file extension based processor (at least that I can find). I think the only way to fix this may be an internal refactor of this plugin to use a different approach for preventing it's rules from running on non-json files (which is the intent of the postprocessor), or to migrate away from the deprecated file-extension-based processor.