Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strconv.ParseBool #76

Closed
AlekSi opened this issue Feb 6, 2017 · 1 comment
Closed

Use strconv.ParseBool #76

AlekSi opened this issue Feb 6, 2017 · 1 comment

Comments

@AlekSi
Copy link
Contributor

AlekSi commented Feb 6, 2017

I noticed that some code paths use == "true". This means that, for example, True will not work. In the same time, bool's default description is True or False.

It's better to use strconv.ParseBool everywhere.
@teepark
Copy link
Collaborator

teepark commented Feb 6, 2017

Yes 100%. I'd merge that PR so fast...

@teepark teepark closed this as completed in 8bf4bbf Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlekSi @teepark