Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the arXiv & ICML paper #8

Closed
zhongwen opened this issue Jul 12, 2015 · 1 comment
Closed

Typo in the arXiv & ICML paper #8

zhongwen opened this issue Jul 12, 2015 · 1 comment

Comments

@zhongwen
Copy link

From the code and Pascanu et. al, I think that Eqn 7 in the arXiv version (or Eqn 2 in the ICML version) should add a tanh after L_0.

And is a y_t missing in the same equation as well? From Bahdanau et al. Appendix part Page 14, p(y_i | s_i, y_{i-1}, c_i)

@kelvinxu
Copy link
Owner

We'll push an updated version of the paper to arxiv soon and clarify this. Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants