Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages with Videos are Broken in Mobile View #55

Closed
jusuchin85 opened this issue Jan 21, 2018 · 5 comments
Closed

Pages with Videos are Broken in Mobile View #55

jusuchin85 opened this issue Jan 21, 2018 · 5 comments

Comments

@jusuchin85
Copy link
Contributor

Hey @kelyvin ,

Notice this on mobile view when there's a Youtube video attached:
image

When viewing the same page on a desktop browser, you can see the heading text after the same Youtube embed:
image

I noticed the same is happening on your blog: https://www.caffeinecoding.com/google-io-2016-in-review/

@kelyvin
Copy link
Owner

kelyvin commented Jan 22, 2018

@jusuchin85 Thanks for reporting this issue! I will investigate right now and see if I can get a quick patch fix in.

@jusuchin85
Copy link
Contributor Author

Great! Thanks, @kelyvin !

@kelyvin
Copy link
Owner

kelyvin commented Jan 22, 2018

Hi @jusuchin85, I think I fixed the issue. Can you try pulling the latest release here (https://github.com/kelyvin/caffeine-theme/releases/tag/v3.0.4) and giving it a try?

Youtube seems to be doing some code injection on video embedding, which dynamically tries to style the page. This seems to have caused issues, so I overrode their style changes with my own. Let me know if this fixes your problem! It seems to be fixed with my post (https://www.caffeinecoding.com/google-io-2016-in-review/).

@jusuchin85
Copy link
Contributor Author

jusuchin85 commented Jan 22, 2018 via email

@jusuchin85
Copy link
Contributor Author

Thanks @kelyvin ! The fix works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants