Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise social links usage. #74

Merged
merged 2 commits into from
Feb 23, 2019
Merged

revise social links usage. #74

merged 2 commits into from
Feb 23, 2019

Conversation

0t2
Copy link
Contributor

@0t2 0t2 commented Feb 12, 2019

Fixes #15
Facebook and Twitter links now grab from general setting, extra configuration as shown below:

// Code injection - Blog Header
<script>
    var socialConfig = {
        facebook: {
            title: "Caffeine Coding on Facebook"
        },
        twitter: {
            title: "@KelyvinN on Twitter"
        },
        linkedIn: {
            link: "https://linkedin.com/in/kelyvin",
            title: "Kelyvin on LinkedIn"
        },
        github: {
            link: "https://github.com/kelyvin",
            title: "Kelyvin on Github"
        }
    };
</script>

assets/js/src/cover.js Outdated Show resolved Hide resolved
@kelyvin
Copy link
Owner

kelyvin commented Feb 19, 2019

HI @0t2,

Sorry for the late reply, was out of town. Thanks for making these changes! Looks great!

I just made one minor comment. Can you also update the readme with the new configuration changes you've implemented? You can update the following section for Social Networks

Thanks!

@kelyvin kelyvin merged commit 7f4de68 into kelyvin:master Feb 23, 2019
@kelyvin
Copy link
Owner

kelyvin commented Feb 23, 2019

Thanks for submitting this change! Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants