Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tables are not known to be scrollable on mobile #27

Closed
EKami opened this issue Dec 12, 2016 · 4 comments
Closed

Some tables are not known to be scrollable on mobile #27

EKami opened this issue Dec 12, 2016 · 4 comments

Comments

@EKami
Copy link

EKami commented Dec 12, 2016

Hi @kelyvin ,
I'm reopening the previous issue #26, the tables on mobiles does not reveal to the user that they are scrollable.
For example with this table:
screenshot_20161212-151219

You can't really know that there is a third column except if you magically scroll horizontally:
screenshot_20161212-151236

Moreover the tables seems to be completely shrank on desktop:
activity_as_context__you_re_doing_it_wrong_

Thank you for your consideration 🙏

@kelyvin
Copy link
Owner

kelyvin commented Dec 12, 2016

Shoot thanks for bringing this to my attention again! I'll need to implement this more thoroughly, I was testing this purely on my laptop screen so I wasn't able to test a proper mobile experience or on a large desktop screen. I'll have a fix for you asap!

@EKami
Copy link
Author

EKami commented Dec 12, 2016

Thanks a lot :)

@kelyvin
Copy link
Owner

kelyvin commented Dec 13, 2016

Hi @EKami,

I have enabled the scrollbar for mobile devices to always be visible. I've also fixed the border issue with the shrunken table. Those can be found in the following release: https://github.com/kelyvin/caffeine-theme/releases/tag/v2.8.2

Regarding the table shrinkage, unfortunately there's no easy way to manage the table width sizing across mobile/desktop devices and support responsiveness. Due to the fact that you can have n number of columns for a table, there's no "one size fits all" solution.

For now this is the best I can do. If you'd like to incorporate a better responsive table solution, feel free to integrate a third party library and create a pull request, but for now this shoot be good for the majority of your use cases. :)

Thanks!

@kelyvin kelyvin closed this as completed Dec 13, 2016
@EKami
Copy link
Author

EKami commented Dec 13, 2016

Okay, thanks a lot for your consideration @kelyvin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants