Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get kemal through shards that has the fix for Crystal 0.35 #572

Closed
xlvg-arjun opened this issue Jun 11, 2020 · 2 comments
Closed

Comments

@xlvg-arjun
Copy link

Description

Can't get the latest version of Kemal with fix for crystal 0.35
[Description of the issue]

I've been trying to run a simple test, running just the example application given in the readme. But I keep getting the Error: undefined constant Gzip::Writer error when I try to run. I've noticed that the latest changes for Crystal 0.35 have been met with #570

Steps to Reproduce

  1. Add dependency for kemal to the shards.yml file. I've tried to set branch as master and give a git link to the project repository
  2. delete out the contents of the lib folder if needed and run shards install
  3. Run a simple example based on what's provided as an example in the front page

Expected behavior: [What you expect to happen]
Everything working as expected

I think if the version in the shards.yml file is bumped up from 0.26.1 to something like 0.26.2 this wouldn't be a problem since shards seems to pull in the latest version based on the tag

@Blacksmoke16
Copy link
Contributor

Yes, a new release needs to be created that contains the comparability PR for 0.35.0. In the meantime you can do:

dependencies:
  kemal:
    github: kemalcr/kemal
    branch: master

@xlvg-arjun
Copy link
Author

Yes, you're right - for some reason I thought the method of specifying the master branch wasn't working and I was about to make a comment here that I was able to get a workaround through specifying the commit instead

Basically

dependencies:
  kemal:
    git: https://github.com/kemalcr/kemal.git
    commit: a8c0f09b858162bd13c96663febef5527b322a32

The method you've provided @Blacksmoke16 works well and this is all that's needed after all. Thanks for responding and being considerate with this noob question! I'll close what I've made here since there's likely actual issues to deal with, and hopefully this would at least help someone if they're just starting to get acquainted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants