Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support view commits by Hash ID on log graph window #492

Closed
watergear opened this issue Sep 26, 2016 · 9 comments
Closed

Support view commits by Hash ID on log graph window #492

watergear opened this issue Sep 26, 2016 · 9 comments

Comments

@watergear
Copy link

No description provided.

@kemayo
Copy link
Owner

kemayo commented Sep 26, 2016

Sensible request, one second, I'll have to lightly rewrite the Graph syntax to make it fit together.

@kemayo kemayo closed this as completed in 47a3228 Sep 26, 2016
@watergear
Copy link
Author

@kemayo I have implemented it few days ago and will make pull request later.
Could you reopen this issue?

@kemayo
Copy link
Owner

kemayo commented Sep 28, 2016

Do I need to? I mean, I already implemented what I think you're asking for...?

@watergear
Copy link
Author

Do you mean the commit cf56cde ?
I suppose to Press a key to show commit when current cursor stay on Hash ID.

Just leave this issue for few days. I will update the details on description.
thanks

@kemayo
Copy link
Owner

kemayo commented Sep 28, 2016

No, I mean 47a3228 -- the one that I closed the task with. It extends the existing "hit enter to go to commit in blame" behavior to also work in graph.

@watergear
Copy link
Author

But I hit enter key and then nothing happens?
What is wrong?

@kemayo
Copy link
Owner

kemayo commented Sep 28, 2016

Hard to say. Assuming there are no errors in the log, it's either that you're pressing enter on a line which doesn't contain a commit hash, or you've not updated to the version which includes the new functionality (I haven't tagged a release since making that change, for one thing).

@watergear
Copy link
Author

Anyway, I will make pull request later and you will see the details.

@kemayo
Copy link
Owner

kemayo commented Sep 28, 2016

Sure, I will be happy to examine it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants