Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morning session: Peer-to-peer code review: 2022-03-31 #7

Open
wuletawwonte opened this issue Mar 31, 2022 · 0 comments
Open

Morning session: Peer-to-peer code review: 2022-03-31 #7

wuletawwonte opened this issue Mar 31, 2022 · 0 comments

Comments

@wuletawwonte
Copy link

Hey @kemigabocatherine! 馃憢 Your project is looking great, Its design looks good 馃挴 So, there are some things we have that will be better to improve.

  • I think it is better to avoid using many front-end libraries because it decreases the page load speed. Especially big libraries with big sizes. For instance, you can remove iconify because you have loaded font awesome already and I think font awesome is enough for your icon needs.
  • And please use Javascript built-in array methods like forEach, map, and filter to loop through arrays instead of for loops. It is okay to use for loops but it would make the code shorter and readable.

Happy coding 馃挭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant