Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseurlpath configuration #59

Open
ablivio opened this issue Dec 27, 2023 · 0 comments
Open

baseurlpath configuration #59

ablivio opened this issue Dec 27, 2023 · 0 comments

Comments

@ablivio
Copy link

ablivio commented Dec 27, 2023

This line probably doesn't do what it was supposed to:

'baseurlpath' => getenv('SIMPLESAMLPHP_IDP_BASE_URL') ?: '' . 'simplesaml/',

. has precedence over ?:, so

  • if the environment variable is defined, baseurlpath will have its value -- instead of <value> . 'simplesaml/'
  • otherwise, baseurlpath will be equal to 'simplesaml/'.

Suggested fix:

'baseurlpath' => (getenv('SIMPLESAMLPHP_IDP_BASE_URL') ?: '') . 'simplesaml/',
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant