User and ip lockout #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 similar comments
2 similar comments
|
@mrbaboon thank you, I'll take a look at this PR shortly. |
|
LGTM @marcusmartins @shin- let me know if it looks good to you. |
|
LGTM |
|
The code LGTM but we should add some docs on usage and behavior. |
|
@marcusmartins I agree, oversight on my part. I'll add the docs in later today or tomorrow then we can close it out. |
Clean up inconsistent styles
|
Docs are added! |
2 similar comments
| @@ -13,7 +13,7 @@ backend best fits their needs. | |||
| Build status | |||
| ------------ | |||
|
|
|||
| [](https://travis-ci.org/kencochrane/django-defender) [](https://coveralls.io/r/kencochrane/django-defender)[](https://landscape.io/github/kencochrane/django-defender/master) | |||
| [](https://travis-ci.org/mrbaboon/django-defender) [](https://coveralls.io/r/kencochrane/django-defender)[](https://landscape.io/github/kencochrane/django-defender/master) | |||
There was a problem hiding this comment.
We probably don't need to change to your status icon, keeping it kencochrane would be best so that it works on master.
|
Ah yes, sorry, missed that in my diff, good catch! |
|
THank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow username and IP to be mutually exclusive when performing lockouts. This resolves an issue where you may have many users behind a single IP (common amongst our enterprise customers) where 1 user forgetting their password will lock out their peers.
The setting changes the lockout checks to evaluate if the IP failure limit and the username failure limit has been reached before issuing the lockout.
Any suggestions or comments are more than welcome!