Allow usernames with plus signs in unblock view #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bug #GH76 where an exception like
```
Reverse for 'defender_unblock_username_view' with arguments '(u'user+test@domain.tld',)' and keyword arguments '{}' not found. 1 pattern(s) tried: [u'admin/defender/blocks/username/(?P[A-Za-z0-9-._@]+)/unblock$']
```
was raised when trying to access the `/admin/defender/blocks/` URL when a user with a plus sign had been locked out.
|
I've added the main urls to the test urls file. I don't know if this is right, actually I don't know why a separate |
dukebody
commented
Jun 9, 2017
|
|
||
| Regression test for #GH76. | ||
| """ | ||
| reverse('defender_unblock_username_view', |
There was a problem hiding this comment.
This just checks it doesn't fail, because if there is no view available a NoReverseMatch is raised.
|
We keep the urls in separate files because this is an app people include in their overall projects and if they decide to use our URL, we want to make sure our testing urls aren't accidentally exposed in their main app. Probably a little paranoid, but better safe then sorry :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #76 where an exception like
was raised when trying to access the
/admin/defender/blocks/URL when a user with a plus sign had been locked out.