Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 1.11 #79

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Conversation

dukebody
Copy link
Contributor

@dukebody dukebody commented Jun 10, 2017

  • Update middleware to work with Django 1.11 and older versions.
  • Add Django 1.11 to the Travis test matrix.
  • Update README to remove mention to Django 1.11 not being supported.
  • Avoid repeated patching using a middleware class-level flag instead of checking function names.

Resolves #78.

@coveralls
Copy link

coveralls commented Jun 10, 2017

Coverage Status

Coverage decreased (-0.2%) to 95.817% when pulling 052cb1a on dukebody:django-1.11 into 69db1cf on kencochrane:master.

@kencochrane
Copy link
Collaborator

@dukebody thank you for adding the Django 1.11 support. It looks like Travis failed because 1.11 doesn't support python 2.6 and 3.3. I think you just need to update the Travis config file so that it doesn't run the tests for those python versions. We do that for other versions as well, so it should be straight forward. If not let me know.

@dukebody
Copy link
Contributor Author

@kencochrane Done!

@coveralls
Copy link

coveralls commented Jun 12, 2017

Coverage Status

Coverage decreased (-0.2%) to 95.817% when pulling 39a2d2b on dukebody:django-1.11 into 11ee7bc on kencochrane:master.

@kencochrane
Copy link
Collaborator

@dukebody thank you! Looks better. going to merge now.

@kencochrane kencochrane merged commit a59cbca into jazzband:master Jun 12, 2017
@dukebody dukebody deleted the django-1.11 branch June 13, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants