Milestone: To Do list: interactive list #4
Conversation
There was a problem hiding this comment.
Hi @kendoriddy,
Good job so far 🔥!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🔥🎉
- Linters ✔
- PR ✔
- Styles ✔
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
✅ Deploy Preview for my-daily-tasks ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Hi @kendoriddy ,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights 💪
- no linter errors
- correct flow is used
- good PR
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @BertrandConxy in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/crud.js
Outdated
|
|
||
| ['focus', 'blur', 'keyup'].forEach((evt) => { | ||
| input.addEventListener(evt, (e) => { | ||
| if (evt === 'blur' || (evt === 'keyup' && e.key === 'Enter')) { | ||
| // It's a modify | ||
| const taskIndex = Number(e.target.id.split('-')[1]); | ||
| saveTodo(taskIndex); | ||
| e.target.blur(); | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
- Good job so far. I can see that you made changes based on the previous reviewer's suggestions. However, the changes you introduced may have caused some bugs in your application. Right now, when I run the application locally, I tried to add a task and when I click
enterthe page reloaded and the task is neither displayed in the UI nor stored in the local storage. Please visit back your function to add a task and check if it is working as before 🙏 As a result, I was not able to check whether the completed functionality is working.
There was a problem hiding this comment.
@BertrandConxy Thanks for your feedback. However, I am able to add new tasks on my local machine without any issue. Can you please try it again? I will add a video to demonstrate functionalities too
There was a problem hiding this comment.
@BertrandConxy here is a video demo of the app
https://www.loom.com/share/6ddf6015b06948108aad29c642d0f804
There was a problem hiding this comment.
Ok. I can see it. It looks like we even have a different UI. Let me review it again
There was a problem hiding this comment.
Hi @kendoriddy ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- no linter errors
- good PR
- good README
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @BertrandConxy in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
For this milestone, I implemented the following
Here is a video demo of the app
https://www.loom.com/share/6ddf6015b06948108aad29c642d0f804