Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No scrollbar when the dropdown for dashboards is taller than the vertical resolution #17

Closed
SEJeff opened this issue Mar 13, 2013 · 2 comments

Comments

@SEJeff
Copy link

SEJeff commented Mar 13, 2013

I used the excellent giraffe-collectd generator to autocreate a dashboards.js file based on all of the collectd hosts that I have in graphite.

The problem is that I've got thousands of hosts in graphite, so the dropdown where it says "Dashboards" is longer than the vertical resolution. Upstream bootstrap doesn't give a crap.

So the solution is simply adding this to bootstrap.js under .dropdown-menu

   max-height: 500px;
   overflow-y: auto;
   overflow-x: hidden;

You could hack this into the index.html via a style attribute as well on the dropdown-menu div, or you could move to using something like select2, which would give you a nice find as you type search of all of the menus. Obviously I can do this quite easily on my own "version" of giraffe, but I'd like to see changes incorporated upstream if possible. What do you think?

@gingerlime
Copy link

Hey @SEJeff - sorry, I somehow missed this issue.

On the face of it, it looks good and I'd be happy to merge this change in, but want to double-check that it doesn't break anything. Something like select2 sounds like a good idea too, and I'll look into it as well at some point.

@nhapke - what's your opinion on this?

@SEJeff
Copy link
Author

SEJeff commented Mar 22, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants