Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Builder Support for where_in, where_or and its variations #12

Closed
jderr-mx opened this issue Feb 24, 2023 · 4 comments · Fixed by #13
Closed

Query Builder Support for where_in, where_or and its variations #12

jderr-mx opened this issue Feb 24, 2023 · 4 comments · Fixed by #13
Assignees
Labels
enhancement New feature or request

Comments

@jderr-mx
Copy link
Contributor

jderr-mx commented Feb 24, 2023

Describe the bug
Thank you for creating this helper, it is quite useful.
I am working on a large project which makes use of where_in and where_or functions from the query builder.
Does this helper support those functions?

Looking at https://github.com/kenjis/ci3-to-4-upgrade-helper/blob/1.x/src/CI3Compatible/Database/CI_DB_query_builder.php

It appear that might be the case.

I am happy to provide more detail if needed. Thanks!

ci3-to-4-migration-helper version
Which version (and branch, if applicable) the bug is in.

Expected behavior, and steps to reproduce if appropriate
A clear and concise description of what you expected to happen,
and how you got there.
Feel free to include a text/log extract, but use a pastebin facility for any
screenshots you deem necessary.

Context

  • OS: [e.g. Windows 99]
  • Web server [e.g. Apache 1.2.3]
  • PHP version [e.g. 6.5.4]
@jderr-mx jderr-mx added the bug Something isn't working label Feb 24, 2023
@kenjis
Copy link
Owner

kenjis commented Feb 25, 2023

Does this helper support those functions?

As you see the code, not yet.

@kenjis kenjis added enhancement New feature or request and removed bug Something isn't working labels Feb 25, 2023
@kenjis kenjis self-assigned this Feb 25, 2023
@kenjis
Copy link
Owner

kenjis commented Feb 25, 2023

Try #13

@jderr-mx
Copy link
Contributor Author

Wow! Thank you for such a quick response! It seems to be working as intended

@kenjis
Copy link
Owner

kenjis commented Feb 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants