Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to get this upstream to 'necolas/normalize.css' ? #27

Closed
iemejia opened this issue Jul 24, 2015 · 2 comments
Closed

Any plans to get this upstream to 'necolas/normalize.css' ? #27

iemejia opened this issue Jul 24, 2015 · 2 comments
Labels

Comments

@iemejia
Copy link

iemejia commented Jul 24, 2015

Hello,

Great work, Do you have any plans (or discussions) to get some (or all) of your changes as part of the upstream 'normalize' project ? It makes sense doesn't it ?

Thanks for the nice defaults.

@briankoser
Copy link

See necolas/normalize.css#343

@kennethormandy
Copy link
Owner

Thanks for your interest in the project, and @briankoser for providing the answer.

I carefully developed this project to make merging it into Normalize.css possible—the testing framework, code, and comment style all referenced the original project. But I was pretty sure it wouldn’t get merged, which is why I didn’t do it as just a pull request from the beginning.

Necolas kindly gave it a try, but wasn’t interested in merging it, which is a totally fair response—it does go beyond the scope of browser defaults and well into typographic conventions.

I will hopefully be doing another pass on the whole thing in the near future, with some tests I can automate. Any changes at this point are likely to move further away from having it merged, but I think that’s okay.

Thanks for opening an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants