Skip to content
This repository has been archived by the owner on Apr 24, 2018. It is now read-only.

status_code in core.py trips up most everything #58

Closed
idella opened this issue Jun 5, 2013 · 1 comment
Closed

status_code in core.py trips up most everything #58

idella opened this issue Jun 5, 2013 · 1 comment

Comments

@idella
Copy link

idella commented Jun 5, 2013

The first thing that falls over is seeking _status_code.
As far as I can tell _status_code isn't actually assigned any value in def status_code(self).

ERROR: test_status_code_success (main.ConnectedCommandTests)

Traceback (most recent call last):
File "test_envoy.py", line 38, in test_status_code_success
self.assertEqual(c.status_code, 0)
File "/mnt/gen2/TmpDir/portage/dev-python/envoy-0.0.2-r1/work/envoy-0.0.2/envoy/core.py", line 80, in status_code
if self._status_code is not None:
AttributeError: 'ConnectedCommand' object has no attribute '_status_code'

I took a punt at copying
self._status_code = self._process.wait()
from further on and it seemed to make a couple of tests pass.

    self.assertEqual(r.std_out, test_string.upper())
    self.assertEqual(r.status_code, 0)

both fail in def test_input(self), line 53, the second one.

envoy-0.0.2 $ PYTHONPATH=. python2.7 test_envoy.py

yields

.......................................................

FAIL: test_input (main.ConnectedCommandTests)

Traceback (most recent call last):
File "test_envoy.py", line 48, in test_input
self.assertEqual(r.std_out, test_string.upper())
AssertionError: None != 'ASDFQWER'

FAIL: test_quoted_args (main.SimpleTest)

Traceback (most recent call last):
File "test_envoy.py", line 26, in test_quoted_args
self.assertEqual(r.std_out.rstrip(), sentinel)
AssertionError: '' != 'quoted_argsquoted_argsquoted_args'


Ran 8 tests in 3.347s

FAILED (failures=2, errors=3)

eeek

@kennethreitz
Copy link
Contributor

This project is in a bit of a crisis state — it's really useful, and I use it on a daily basis. However, I wrote it in a few afternoons several years ago and haven't touched it since. In order to get the project into a stable state I'm closing all issues and pull requests

Don't take this as aggressive — it's just necessary for the project to make any progress any time soon (it's pretty clear the project is effectively unmaintained at the moment). Great things to come! Please watch the GitHub logs and feel free to re-open this discussion soon. I just need to really it into a good state first.

✨ ❤️ ✨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants