This repository has been archived by the owner on Apr 24, 2018. It is now read-only.
Checks platform.system to determine POSIX mode #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… better than before, but it still fails some cases.
…gns, pipes, and quotes. The quotes need more testing of edge cases.
…te surrounding it, gs does not strip it out. Since " is invalid for filenames on windows, this does not work. I've configured it to only parse once over the input string, thus avoiding the original reason for switching to Non posix mode. Also, it is set up to allow setting of posix mode manually if the user needs to. Non posix mode still handles quotes slightly oddly, in that if a command such as -I"c:/program files/gs/gs9.05/fonts" is input, two tokens are returned. This can be fixed, if necessary, in Non posix mode since tokens are examined individually, instead of just using shlex.split() and getting a list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a quoting issue with the shlex module in expand_args on windows. Under posix mode, words in
"are expanded. So,'cat "c:/program files/test.txt"'gets passed in as['cat', 'c:/program files/test.txt']. With the double quotes removed, the underlying windows os sees two arguments, and fails to find either.I've added a variable
POSIXto holdTrueorFalsebased upon the results fromplatform.system(). Anything that needs to check posix mode should use this value.