Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple clients with different configurations #100

Closed
maltesa opened this issue Jun 25, 2021 · 1 comment · Fixed by #99
Closed

multiple clients with different configurations #100

maltesa opened this issue Jun 25, 2021 · 1 comment · Fixed by #99

Comments

@maltesa
Copy link
Contributor

maltesa commented Jun 25, 2021

I need to run multiple clients with different configurations. As I understand the current implementation the configuration is a "global" singleton class. Hence, each instance of Client uses the same Instnace of Configuration.

I tried to address that with #99

What do you think?
@pietromenna pietromenna linked a pull request Sep 7, 2021 that will close this issue
Allow to use different configurations in parallel #99
Merged
@pietromenna
Copy link
Collaborator

Hey @maltesa. It looked great! Thanks for for the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to use different configurations in parallel maltesa/wikipedia-client
2 participants
@pietromenna @maltesa