Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop throws up a lot of offenses #51

Closed
harman28 opened this issue May 22, 2017 · 2 comments
Closed

Rubocop throws up a lot of offenses #51

harman28 opened this issue May 22, 2017 · 2 comments

Comments

@harman28
Copy link
Contributor

I installed and ran rubocop on the codebase:

> 19 files inspected, 351 offenses detected

The full results are here.

Many of these are style decisions rather than offenses, and can be filtered out by using the right preferences in a .rubocop.yml file. However, some are genuine issues, and can use some work.

Would be happy to take this up myself (if you see the merit in it), but I'll need occasional help and reviews from more experienced contributors whenever it comes a style decision.

@pietromenna
Copy link
Collaborator

@harman28: Is this solved by #54 ?

@harman28
Copy link
Contributor Author

Yep!

wikipedia-client (master) > rake rubocop
Running RuboCop...
Inspecting 19 files
...................

19 files inspected, no offenses detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants