Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #124

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Bugfix #124

merged 2 commits into from
Oct 20, 2017

Conversation

airycanon
Copy link
Contributor

有两个菜单漏了名字,不知道跟 #97 是不是同一个问题

#113 原因在这段代码

function includeStyle( $target, style, cls, type ) {
    var bakstyle;
    if ( type === "add" ) {
        bakstyle = $target.attr( "style" ) == undefined ? "" : $target.attr( "style" );
        $target.attr( "style", bakstyle + style ).addClass( cls );
    } else if (  type === "delete" ) {
        bakstyle = $target.attr( "style" );
        bakstyle = bakstyle.replace( style, "" );
        $target.attr( "style", bakstyle ).removeClass( cls );
    }
}

这里的 $target 有可能有多个,$target.attr( "style" ) 取的是第一个对象的样式,而 $target.attr( "style", bakstyle + style ) 则是给所有的对象更改样式。

@Kenshin
Copy link
Owner

Kenshin commented Sep 28, 2017

cool~ 等合并到 develop 时,我会确认的~ 👍 😀

@Kenshin
Copy link
Owner

Kenshin commented Oct 19, 2017

已经合并了代码,关于 tooltip 的问题并不是你所说。

之所以没有加 PNG PDF 的 tooltip 是因为这两个 service 再使用时会把 tooltip 也截图,为了避免这个问题而已。

👍

@airycanon
Copy link
Contributor Author

😅 好的,坐等 1.0.4。

@Kenshin
Copy link
Owner

Kenshin commented Oct 19, 2017

@airycanon
顺利的话,估计本周内发布~
不过,已经合并你对 #113 的修改了~ 👍

@Kenshin Kenshin merged commit 7b1bffd into Kenshin:develop Oct 20, 2017
@airycanon airycanon deleted the bugfix branch October 22, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants