Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加minimatch和markdown转换功能 #16

Closed
wants to merge 6 commits into from

Conversation

ksky521
Copy link

@ksky521 ksky521 commented Jun 15, 2017

增加minimatch做findSiteByUrl

对于github issue内的文章可以用:

{
    "name": "github.issue",
    "url": "https://github.com/*/*/issues/*",
    "title": "[[{$('h1.gh-header-title .js-issue-title').text()}]]",
    "desc": "",
    "include": "[[{$('#discussion_bucket table td.js-comment-body').html()}]]",
    "exclude": ""
}

增加markdown转换

阅读模式下控制器增加转换markdown

@Kenshin
Copy link
Owner

Kenshin commented Jun 15, 2017

cool~
准备明天开始弄 1.0.1,到时候可以一起发布!

PS:之前没注意到,原来是你,很久之前有过交流 :)

@ksky521
Copy link
Author

ksky521 commented Jun 15, 2017

今天匆忙改的,可能有地方写的不太合适,你有空可以优化下~ 另外发现了退出阅读模式之后,有个class没有删除,追个commit

@Kenshin
Copy link
Owner

Kenshin commented Jun 15, 2017

minimatch 的方式很棒。
最初没考虑太多,所以 URL 自己写的匹配,后来越来越多,所以打算等有空重新改改…
你说的 bug 我也发现了,感谢 Fix

估计 markdown 的显示流程可能会有些改动,但逻辑照旧。

默认把markdown textarea隐藏
@ksky521
Copy link
Author

ksky521 commented Jun 15, 2017

哈哈~ 我觉得minimatch可以给你省不少代码~

@Kenshin
Copy link
Owner

Kenshin commented Jun 15, 2017

的确能省不少代码。 😃
话说你是不是用了代码格式化工具? 各种空格都没有了,哈哈。

@ksky521
Copy link
Author

ksky521 commented Jun 15, 2017

手欠,貌似两个文件格式化了一下。。

@Kenshin
Copy link
Owner

Kenshin commented Jun 15, 2017

storage 与 site 吧,找了半天也没发现哪里改了…
早年间跟日本做项目时养成的习惯,懒得改了。
权当个人风格了。😁

@Kenshin
Copy link
Owner

Kenshin commented Jun 16, 2017

markdown 转换 功能 是想提供 Markdown 方式的下载吗?

@ksky521
Copy link
Author

ksky521 commented Jun 16, 2017

有时候转文章时候,编辑器可以用Markdown语法,图个方便

@Kenshin
Copy link
Owner

Kenshin commented Jun 16, 2017

👍 好想法,这样就可以有两种转换方式,随便切换哪种都 OK 。
这两天收集了 v2 上的一些建议,准备把这些细节打包成 实验室,也把这个功能放进去~ ,或者其它方式,我再想想如何更好的告知用户。

PS:我也顺道加了个 download md 的功能...

@Kenshin
Copy link
Owner

Kenshin commented Jun 17, 2017

已经 merge pr 了,由于用 git --no-ff 会产生一些不必要的 commit,所以手欠的用了 git merge --squash 导致你的信息被合并掉了... 😭

@Kenshin Kenshin closed this Jun 17, 2017
@ksky521
Copy link
Author

ksky521 commented Jun 26, 2017

没事~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants