Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pytest 6.* #8

Closed
Querela opened this issue Apr 15, 2021 · 4 comments
Closed

Support pytest 6.* #8

Querela opened this issue Apr 15, 2021 · 4 comments

Comments

@Querela
Copy link

Querela commented Apr 15, 2021

Current version of pytest is something like 6.2.3. The package requires a pytest version lower than 6 which only allows for pytest==5.4.3.
Not sure whether changes are required, as the example is from 2018. This seems different:

@pytest.fixture(autouse=True)
def collect_types_fixture():
    from pyannotate_runtime import collect_types
    collect_types.start()
    yield
    collect_types.stop()

https://github.com/dropbox/pyannotate/blob/1e7ddf09fdbc6fa37b2cf261f36a5563a0fe772a/example/example_conftest.py#L18-L23

@obi1kenobi
Copy link
Contributor

That does seem like a different approach. At this point, I'm not sure if that example simply wasn't around when I wrote this plugin, or if there was a specific reason to go with another approach.

If you'd like to open a PR updating the plugin to use that approach and updating the pytest bound to <7, I'd be happy to approve it and publish a new version.

@Querela
Copy link
Author

Querela commented Apr 15, 2021

I can look into it but I'm not sure how to test it besides on some of my own projects.
And I can also not guarantee some timeline. Just updating the setup.py might not be enough.

@obi1kenobi
Copy link
Contributor

I'm in the same boat 😄 Thanks for looking into it!

@obi1kenobi
Copy link
Contributor

Closed by #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants