fix presumably busted unemptyString #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to assert that a function was passed an unempty string, so I wrote something like the following:
I found that this did not throw an exception. Upon further investigation,
verify
only throws when the result of a comparison is strictlyfalse
. I modifiedunemptyString()
to ensure it always returns aboolean
value.To assert my changes worked, I attempted to run
npm test
. However, the unit tests were not executed--not sure why. I enabled them as part of this PR. If you would like me to disable them again, I can remove 398a986.