Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

based on jdk9 Or later not based on jdk8 #2

Closed
shyding opened this issue Oct 29, 2020 · 5 comments
Closed

based on jdk9 Or later not based on jdk8 #2

shyding opened this issue Oct 29, 2020 · 5 comments

Comments

@shyding
Copy link

shyding commented Oct 29, 2020

No description provided.

@kenta-shimizu
Copy link
Owner

Hi,
Exclude 'module-info.java', if using jdk8, or if it interferes on compile.
I will append this discription to 'module-info.java' comment.
Thanks regards.

@kenta-shimizu
Copy link
Owner

I mistake.
I use 'Collectors#toUnmodifiableList'(from 10)
And use 'Collection#toArray​(IntFunction<T[]>)'(from 11)
Thanks regards.

@kenta-shimizu
Copy link
Owner

Bug fixed.

@shyding
Copy link
Author

shyding commented Nov 7, 2020

If you're inclined to keep the file module.java After all, manually Exclude
this file is always one step more, which is very inconvenient for development

@kenta-shimizu
Copy link
Owner

This repository is Apache License 2.0.
Fork to your repository and rewrite.
I hope your development environment will be comfortable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shyding @kenta-shimizu