Skip to content

Commit

Permalink
Revert "Revert "Fix IE leaks caused by ._fireEvent circular reference""
Browse files Browse the repository at this point in the history
This reverts commit 14f5deb.
  • Loading branch information
kentaromiura committed Apr 13, 2012
1 parent 14f5deb commit 86611be
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion Source/Element/Element.js
Expand Up @@ -800,18 +800,20 @@ var formProps = {input: 'checked', option: 'selected', textarea: 'value'};
Element.implement({

destroy: function(){
if(! this.getElementsByTagName) return null; //textNode
var children = clean(this).getElementsByTagName('*');
Array.each(children, clean);
Element.dispose(this);
return null;
},

empty: function(){
Array.from(this.childNodes).each(Element.dispose);
Array.from(this.childNodes).each(Element.destroy);
return this;
},

dispose: function(){
this._fireEvent = null;
return (this.parentNode) ? this.parentNode.removeChild(this) : this;
},

Expand Down Expand Up @@ -949,6 +951,13 @@ Element.Properties.html = {

};

// fix for IE leak on Element.set('text','')
Element.Properties.text = {
set: function(text){
Element.prototype.empty.call(this).setProperty('text',text);
}
}

var supportsHTML5Elements, supportsTableInnerHTML, supportsTRInnerHTML;

/*<ltIE9>*/
Expand Down

0 comments on commit 86611be

Please sign in to comment.