Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support more extensions that babel macros can be written in #175

Merged
merged 2 commits into from May 5, 2021

Conversation

quantizor
Copy link
Contributor

What:

Babel macros that are written in typescript and not transpiled prior to being run through babel-plugin-macros are currently not detected because resolve defaults to only looking for the ".js" extension.

@quantizor
Copy link
Contributor Author

@kentcdodds would love to get this in if possible, I'm converting styled-components to TS and testing our babel macro written in TS is proving challenging without this

src/index.js Outdated Show resolved Hide resolved
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #175 (d77b3c8) into main (d613985) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          130       130           
  Branches        38        38           
=========================================
  Hits           130       130           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d613985...d77b3c8. Read the comment docs.

@kentcdodds kentcdodds merged commit 856e5f4 into kentcdodds:main May 5, 2021
@kentcdodds
Copy link
Owner

@all-contributors please add @probablyup for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @probablyup! 🎉

@github-actions
Copy link

github-actions bot commented May 5, 2021

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@quantizor
Copy link
Contributor Author

@kentcdodds thanks for taking this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants