-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to TypeScript #86
Conversation
chore: add tsconfig and prepare package.json for typescript conversion
feat: update object-to-ast.js and helpers.js to TS
This is the first cut, cleanup to come. Fixes #7
feat: migrate index.js to TS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I just have one comment.
test: Migrate __tests__/macro.js to TypeScript
fix: restore original logic for `transformFromAst` in `index.ts`
test: Migrate __tests__/index.js to TypeScript
feat: migrate macro.js to TypeScript
@kentcdodds, I've marked this as ready for review as all the files have been migrated, with tests passing and no linting errors. At this point of the raid, we welcome you to leave any comments or raise any concerns for the raid party to take on. |
fix: move @types/babel__core to prod dependencies
Sweet! Thanks everyone 👏👏 |
@all-contributors please add @nobrayner for code |
I've put up a pull request to add @nobrayner! 🎉 |
@all-contributors please add @JacobMGEvans for code |
I've put up a pull request to add @JacobMGEvans! 🎉 |
@all-contributors please add @juhanakristian for code |
I've put up a pull request to add @juhanakristian! 🎉 |
@all-contributors please add @Aprillion for code |
I've put up a pull request to add @Aprillion! 🎉 |
@all-contributors please add @mpeyper for code |
I've put up a pull request to add @mpeyper! 🎉 |
This change hasn't been published to npm, has it? Inspecting https://unpkg.com/browse/babel-plugin-preval@5.0.0/package.json I don't see any references to |
Ah yeah, looks like this repo was never updated to use github actions to auto-release stuff. Bummer. I'm afraid I don't have the bandwidth to work on this :( |
Is there anything I can do to help set up publishing? I could presumably copy the action definition from another one of your repos? |
Hi @kentcdodds, if you want, I can look at getting a pipeline set up for you. Would still need someone to merge a PR for it (I understand that you may not have the bandwidth for even that right now) |
I can merge a PR 👍 |
@NMinhNguyen you offered first, so happy to let you take it. I will review the PR for it if you want. You can likely follow what has been done in |
@mpeyper thanks for the pointer! I can have a look a bit later but if you don't see a PR from me in the next 24 hours, feel free to raise one yourself :) |
Put up a PR: #100 |
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Migrate to TypeScript.
Why:
@kentcdodds approached the Open Source Raid Guild with a quest to migrate this repo to TypeScript.
How:
Minimal upgrade to introduce type safety and generate type definitions while adhearing to good TypeScript practices. We want to keep functional changes within the plugin as little as possible.
Kent suggested that it would be fine to follow the approaches taken in
babel-plugin-codegen
when it was migrated when it was migrated.This PR will be kept in a draft state while the raid is in progress so that the repo maintainers can see the current state of the migration.
The repo has been forked for the raid party to use for our own planning and coordination and planning, but you are welcome to participate in the issues and pull requests that occur there if you wish.
You can also keep track of the raid stats on our (work-in-progress) website.
Finally, you are invited to join us in the ⚔️-OSS-RAID section of the KCD discord server to chat with us about the changes and keep up to date with the work happening within the raid party.
src
files__test__
files.d.ts
files to root