'lodash.assign' vs 'Object.assign'

[wtgtybhertgeghgtwtg]

For how it it used, wouldn't Object.assign work over lodash.assign? I tried swapping them out and the tests all passed. dist was .22kb lighter, too.
If I'm not missing something here, I can submit a Pull Request.

[kentcdodds]

If we do that, we'd have to drop support for Node < 4 which is fine, we'd just need to push a breaking change. Feel free to file a PR.

[wtgtybhertgeghgtwtg]

Oh, right, main points to src.
Filed in #29. Hope I formatted the commit right.

[DavidWells]

Looks like this is breaking in electron. Ref: https://gist.github.com/DavidWells/2c79ce5864f2b3c224423c7db53b3b17

https://github.com/chentsulin/electron-react-boilerplate/ throws when trying to run the npm run dev command.

Should we revert this back to lodash for now? =)

[kentcdodds]

Sorry, Object.assign is supported in all environments version of node that cross-env targets (>=4). My guess is there's something odd about your environment. You can use an older version of cross-env if you need to.

[DavidWells]

Thanks Kent!

Take the day off for your birthday. You deserve it.

I'll figure this out :)

On Oct 18, 2016, at 8:33 AM, Kent C. Dodds notifications@github.com wrote:

Sorry, Object.assign is supported in all environments version of node that cross-env targets (>=4). My guess is there's something odd about your environment. You can use an older version of cross-env if you need to.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.