fix: stop ignoring current subject when inside a .within

testing-library · Sep 2, 2021 · 1af9f2f · 1af9f2f
1 parent 53e76f6
commit 1af9f2f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/cypress/integration/find.spec.js b/cypress/integration/find.spec.js
@@ -119,6 +119,20 @@ describe('find* dom-testing-library commands', () => {
     })
   })
 
+  it('findByText inside within and with a previous subject', () => {
+    cy.get('section:nth-of-type(2)').within(() => {
+      cy.findByText(/Button Text 1/).should('exist')
+    })
+    cy.get('#nested')
+      .findByText(/Button Text/)
+      .should('exist')
+    cy.get('section:nth-of-type(2)').within(() => {
+      cy.get('#nested')
+        .findByText(/Button Text/)
+        .should('exist')
+    })
+  })
+
   it('findByText works when another page loads', () => {
     cy.findByText('Next Page').click()
     cy.findByText('New Page Loaded').should('exist')

diff --git a/src/utils.js b/src/utils.js
@@ -6,8 +6,10 @@ function getFirstElement(jqueryOrElement) {
 }
 
 function getContainer(container) {
+  const subject = cy.state('subject')
   const withinContainer = cy.state('withinSubject')
-  if (withinContainer) {
+
+  if (!subject && withinContainer) {
     return getFirstElement(withinContainer)
   }
   return getFirstElement(container)