Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default command timeout value from Cypress config. #22

Merged
merged 1 commit into from
Nov 8, 2018
Merged

fix: use default command timeout value from Cypress config. #22

merged 1 commit into from
Nov 8, 2018

Conversation

adrians5j
Copy link
Contributor

@adrians5j adrians5j commented Nov 8, 2018

What:

Why:
Developers would expect cypress-testing-library commands to respect defaultCommandTimeout value (this value can be set via cypress.json).

How:
We just replaced the hard-coded 3000 ms with Cypress.config().defaultCommandTimeout.

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

At this point, I'm just not sure what would be the most appropriate way to test this, any advice? Would it be better to test this with cypress or with jest ?

Thanks!

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great 💯

@kentcdodds kentcdodds merged commit 16f8c65 into testing-library:master Nov 8, 2018
@kentcdodds
Copy link
Member

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@adrians5j
Copy link
Contributor Author

Well that was fast, thanks 🥇

@kentcdodds
Copy link
Member

🎉 This PR is included in version 2.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting defaultCommandTimeout in cypress.json is not applied
2 participants