Add tests to verify error messages thrown by commands

[misoguy]

This PR adds tests to verify this issue I added in https://github.com/kentcdodds/dom-testing-library

This PR is intended to fail.
When the issue at dom-testing-library resolves and the dependency is updated with a new release, this test should pass.

• Documentation
• Tests
• Ready to be merged
• Added myself to contributors table

[kentcdodds]

Sweet! Thank you!

[misoguy]

Also, the test getAllByText fails on cypress 3.1.2 but passes on 3.0.1 which causes the test to fail on CI.

[misoguy]

I just confirmed that it works on 3.1.1. It seems like something broke on 3.1.2.
I'll add an issue on cypress regarding this break.

[kentcdodds]

Let's keep this open until dom-testing-library had been updated and published here

[misoguy]

Yeah, that's what I was thinking. When dom-testing-library is published I'll update the dependency in this PR and add contributor as well :)

[kentcdodds]

Should be ready

[misoguy]

@kentcdodds Dependency is updated 👍 I think the CI will still fail on one test due to the issue with cypress

[kuceb]

@kentcdodds @misoguy One of your dom utilities is yielding an array of native dom elements, and cypress commands expect jquery element arrays. Cypress previously wrapped the array in jquery but this was undefined behavior, thus it was not captured in a spec and changed unknowingly in 3.1.2.

We've decided to add that functionality to the spec and will have this fix out in a patch release. so your tests will pass after the next patch release

see cypress-io/cypress#2820 (comment)

[misoguy]

@bkucera Thank you!

[misoguy]

@kentcdodds Could we have this merged and released? The issue on cypress seems to be taking a bit more time than anticipated and my tests are spitting too much dom nodes on failing tests. 😞 We could fix the cypress devDependencies on this repo to 3.1.1 which would fix the test failing in CI temporarily.

[kentcdodds]

It can't be released until CI is passing (releases are automated).

[misoguy]

CI will pass if we change the version of cypress in the devDependencies on this repo to a fixed version 3.1.1. But I'm not sure if you are ok with that change or you would like to wait for cypress to fix the issue.

[kentcdodds]

Let's go ahead and lock the version for now

[misoguy]

I locked the cypress version and had to update a snapshot testing due to dom-testing-library version update.

[kentcdodds]

Great, thanks!

[misoguy]

My pleasure 😄

[kentcdodds]

🎉 This PR is included in version 2.3.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀