Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose @testing-library/dom#configure to support configuring the testIdAttribute #81

Conversation

sebinsua
Copy link
Contributor

@sebinsua sebinsua commented Aug 29, 2019

What:

We should be able to configure the library using the same configure function as provided by @testing-library/dom.

Why:

I'm currently working at an organisation in which the components all use a custom test id attribute.

How:

I exported @testing-library/dom#configure from the index.js.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this 👍

@kentcdodds kentcdodds merged commit 3ada0f2 into testing-library:master Aug 29, 2019
@kentcdodds
Copy link
Member

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexkrolick pushed a commit to testing-library/testing-library-docs that referenced this pull request Oct 18, 2019
`configure` is exported as of testing-library/cypress-testing-library#81 / version 4.2.0

Update documentation to describe `configure` usage with cypress.
superT999 added a commit to superT999/testing-library-docs that referenced this pull request Feb 13, 2023
`configure` is exported as of testing-library/cypress-testing-library#81 / version 4.2.0

Update documentation to describe `configure` usage with cypress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants