Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test for wait (#131) #134

Merged
merged 1 commit into from Oct 22, 2018

Conversation

TaylorBriggs
Copy link
Contributor

What:

Fixes flaky test for wait (#131)

Why:

Random test failures prevent builds from shipping.

How:

Use jest timer mocks.

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks!

@TaylorBriggs
Copy link
Contributor Author

Thanks for the library, I'm excited to try it out!

@kentcdodds kentcdodds merged commit f29f551 into testing-library:master Oct 22, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 3.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants