fit(TS): Update TypeScript definitions for getQueriesForElement change #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, I just realized that I let a typo slip through in the commit message. I'll push a manual release 👌 |
kentcdodds
pushed a commit
that referenced
this pull request
May 17, 2018
There was an issue with a patch release, so this manual-releases.md change is to release a new patch version. Reference: #40
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Cool, thanks. Did I make the typo? |
|
We both did. The commit said |
|
🤦♂️ oops, sorry. don't know how that happened. 🤷♂️ thanks for resolving the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Updated the TypeScript definitions to match the change from bindElementToQueries to getQueriesForElement
Why:
The TS definitions are out of date and are showing the wrong/old function being available.
How:
Renamed the file and its exported function
Checklist:
I also update the CONTRIBUTING.md file to remove the
-sflag to thesetupNPM script as the script already adds that flag.