Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move size-snapshot behind a flag #57

Merged
merged 1 commit into from
Aug 12, 2018
Merged

feat: move size-snapshot behind a flag #57

merged 1 commit into from
Aug 12, 2018

Conversation

alexandernanberg
Copy link
Contributor

@alexandernanberg alexandernanberg commented Aug 12, 2018

What:
Don't generate a .size-snapshot.json file by default

Why:
Does not make sense for libraries like react-testing-library and other non browser related libs to generate this file

How:
Hide the functionality behind a --size-snapshot flag

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table N/A

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@kentcdodds kentcdodds merged commit 5aac37c into kentcdodds:master Aug 12, 2018
@kentcdodds
Copy link
Owner

🎉 This PR is included in version 0.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alexandernanberg alexandernanberg deleted the move-size-snapshot-behind-flag branch August 12, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants