Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add baseSort configuration option #95

Merged
merged 3 commits into from Jul 15, 2020

Conversation

tannerlinsley
Copy link
Contributor

@tannerlinsley tannerlinsley commented Jul 14, 2020

What: Added a baseSort configuration option

Why: Ability to override the default stable sort for tie-breaker items

How: By adding a new configuration option and implementing some inversion of control and a new default

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table (I'm assuming I can do this with the bot after this)

@tannerlinsley
Copy link
Contributor Author

@all-contributors please add tannerlinsley for code

@allcontributors
Copy link
Contributor

@tannerlinsley

I've put up a pull request to add @tannerlinsley! 🎉

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          152       156    +4     
  Branches        39        38    -1     
=========================================
+ Hits           152       156    +4     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2cbc7...55ceeeb. Read the comment docs.

@tannerlinsley
Copy link
Contributor Author

Looks like the test failed, but I can't really decipher why.

@kentcdodds kentcdodds merged commit 4d233b7 into kentcdodds:master Jul 15, 2020
@kentcdodds
Copy link
Owner

Thanks!

@kentcdodds
Copy link
Owner

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants