Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguous characters from auto-generated shortcodes #19

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

jakejarvis
Copy link
Contributor

Hi there! Feel free to reject if this is too opinionated but I think this could be a valuable improvement in general.

What:

Removed the following from the possible string of characters:

l, I, 1, O, 0

Why:

These can cause confusion when re-typing a shortcode being read from print, especially with some fonts.

http://example.com/OlI01http://example.com/OlI01

Inspired by the "Avoid Ambiguous Characters" setting in the password generation feature of 1Password.

How:

Modified possible alphanumeric string in utils.js.

Checklist:

  • Documentation (N/A)
  • Tests (N/A)
  • Ready to be merged
  • Added myself to contributors table

l, I, 1, O, 0 can cause confusion when reading URLs from print.
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. I personally rarely (never?) use this feature anyway. Thanks!

@kentcdodds
Copy link
Owner

I gotta do a tooling upgrade for this repo. I'll get to this as soon as I can. Sorry for the delay.

@jakejarvis
Copy link
Contributor Author

No need to apologize, this has been working great for me! Thanks! :)

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8a01aff). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #19   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?     35           
  Branches          ?      7           
=======================================
  Hits              ?     35           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a01aff...e34240c. Read the comment docs.

@kentcdodds kentcdodds merged commit 17f5732 into kentcdodds:master Jan 28, 2020
@kentcdodds
Copy link
Owner

@all-contributors please add @jakejarvis for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @jakejarvis! 🎉

@kentcdodds
Copy link
Owner

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants