-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ambiguous characters from auto-generated shortcodes #19
Remove ambiguous characters from auto-generated shortcodes #19
Conversation
l, I, 1, O, 0 can cause confusion when reading URLs from print.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. I personally rarely (never?) use this feature anyway. Thanks!
I gotta do a tooling upgrade for this repo. I'll get to this as soon as I can. Sorry for the delay. |
No need to apologize, this has been working great for me! Thanks! :) |
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 1
Lines ? 35
Branches ? 7
=======================================
Hits ? 35
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
@all-contributors please add @jakejarvis for code |
I've put up a pull request to add @jakejarvis! 🎉 |
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi there! Feel free to reject if this is too opinionated but I think this could be a valuable improvement in general.
What:
Removed the following from the
possible
string of characters:Why:
These can cause confusion when re-typing a shortcode being read from print, especially with some fonts.
http://example.com/OlI01 —
http://example.com/OlI01
Inspired by the "Avoid Ambiguous Characters" setting in the password generation feature of 1Password.
How:
Modified
possible
alphanumeric string inutils.js
.Checklist: