Fix bug when running shorten with no arguments #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 38 38
Branches 8 8
=========================================
Hits 38 38 Continue to review full report at Codecov.
|
|
@all-contributors please add @SebJones for code |
|
I've put up a pull request to add @SebJones! 🎉 |
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR fixes an error that is thrown when running shorten with no arguments (to format the redirects file).
Why:
addProtocolIfMissing() was being called on the on the longLink (first) argument from the command line, before checking if it had actually been provided.
How:
index.js now checks for the existence of the first argument before attempted to modify it.
Checklist:
Additional commments:
No tests currently for non utility function code - should we add some?