Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render): add wrapper component option #303

Merged
merged 5 commits into from
Feb 19, 2019

Conversation

alexkrolick
Copy link
Collaborator

@alexkrolick alexkrolick commented Feb 16, 2019

What:

Closes #296 - allows adding a wrapper component to render

Why:

to make it easier to write custom render functions for common HOCs and data/context providers

How:

Checklist:

typings/index.d.ts Outdated Show resolved Hide resolved
kentcdodds
kentcdodds previously approved these changes Feb 19, 2019
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. This is great 💯

@kentcdodds
Copy link
Member

Whoops, there's a merge conflict

@alexkrolick
Copy link
Collaborator Author

(Fixed the conflict)

@kentcdodds kentcdodds merged commit e49a23f into testing-library:master Feb 19, 2019
@kentcdodds
Copy link
Member

Thanks!

@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexkrolick added a commit to testing-library/testing-library-docs that referenced this pull request Feb 20, 2019
- Adds docs for render option "wrapper": testing-library/react-testing-library#303
- Reorganizes the API and Setup pages for rtl slightly to add better heading structure for the right navbar.

Accidentally got remotes mixed up - this reverts the revert that prematurely merged the change.

This reverts commit c47aae0.
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
…sting-library#303)

BREAKING CHANGE: The DOM Testing Library version 7.9.0 or greater is required
superT999 added a commit to superT999/testing-library-docs that referenced this pull request Feb 13, 2023
- Adds docs for render option "wrapper": testing-library/react-testing-library#303
- Reorganizes the API and Setup pages for rtl slightly to add better heading structure for the right navbar.

Accidentally got remotes mixed up - this reverts the revert that prematurely merged the change.

This reverts commit c47aae0c8b92b71be73ac64cda0453f13c434642.
web3gru pushed a commit to web3gru/testing-library-docs that referenced this pull request May 13, 2023
- Adds docs for render option "wrapper": testing-library/react-testing-library#303
- Reorganizes the API and Setup pages for rtl slightly to add better heading structure for the right navbar.

Accidentally got remotes mixed up - this reverts the revert that prematurely merged the change.

This reverts commit c47aae0c8b92b71be73ac64cda0453f13c434642.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants