Improved readability of the VIN model, in addition to minor changes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kent-tri
suggested changes
Mar 25, 2020
model.py
Outdated
| :param k: number of iterations | ||
| :return: logits and softmaxed logits | ||
| """ | ||
| h = self.h(input_view) # intermediate output |
There was a problem hiding this comment.
nit: Please capitalize the first letter for the new comments
There was a problem hiding this comment.
That's a good point! Fixed it.
model.py
Outdated
| v, _ = torch.max(q, dim=1, keepdim=True) | ||
| for i in range(0, config.k - 1): | ||
|
|
||
| for i in range(k): |
There was a problem hiding this comment.
This should be range(k-1) to stick with the paper
There was a problem hiding this comment.
I see! I made a compromising commit by extracting the q evaluation step as a separate function.
|
In addition to the fixes you suggested, I also refactored the |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main modification is in the forward method of the model where you extract the q_out from the q values, and not repeating q = F.conv2d(...) in two places. I also made minor improvements, such as adding argparse in the dataset creation script and changing .cuda() into .to(device) in test.py.