Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN services do not have the 1.8 version #3138

Closed
Ellf opened this issue Sep 22, 2017 · 15 comments
Closed

CDN services do not have the 1.8 version #3138

Ellf opened this issue Sep 22, 2017 · 15 comments

Comments

@Ellf
Copy link

Ellf commented Sep 22, 2017

Documentation refers to using CDN services as detailed below:

CSS
<link rel="stylesheet" type="text/css" href="//cdn.jsdelivr.net/jquery.slick/1.8.0/slick.css"/>

JS
<script type="text/javascript" src="//cdn.jsdelivr.net/jquery.slick/1.8.0/slick.min.js"></script>

However, the 1.8 versions are not available on jsdeliver.net nor cdnjs.com/libraries/slick-carousel.

Thanks.

@MartinKolarik
Copy link
Contributor

There are working 1.8.0 links in the readme. jsDelivr website (and cdnjs too, I believe) doesn't list 1.8.0 because it isn't on npm. Related: #3093 (comment)

@yahya-uddin
Copy link

+1. Please fix up the docs!

@PWaddict
Copy link

PWaddict commented Oct 2, 2017

On https://cdnjs.com/libraries/slick-carousel the latest version is 1.7.1. Please upload the 1.8.0 version.

@kenwheeler
Copy link
Owner

Published, should propagate soon

@EvilJordan
Copy link

"Couldn't find the requested release version 1.8.0." Appearing as of 21 days after this issue was closed.

@MartinKolarik
Copy link
Contributor

@EvilJordan what file/url were you trying to access?

@kukac7
Copy link

kukac7 commented Oct 25, 2017

@MartinKolarik
Copy link
Contributor

@EvilJordan
Copy link

Direct from the website "Get it now" section (http://kenwheeler.github.io/slick/#go-get-it), neither of these work:
cdn.jsdelivr.net/jquery.slick/1.8.0/slick.css
cdn.jsdelivr.net/jquery.slick/1.8.0/slick.min.js

@MartinKolarik
Copy link
Contributor

I'll send a PR to fix the website

Or not, as I can't find the correct repo. @kenwheeler ?

@ADTC
Copy link

ADTC commented Jan 21, 2018

What's happening? I am shocked that the CDN version doesn't work. I guess I have no choice but to download and install if CDN reliability cannot be guaranteed.

@MartinKolarik
Copy link
Contributor

@ADTC the CDN works, this is just an issue with documentation. See my previous comment for correct links.

@ADTC
Copy link

ADTC commented Jan 21, 2018

Thank you! Yes, I used the npm links. Hopefully that doesn't change. The documentation is also not clear about the two css files. Is the main one required but the theme one optional?

@MartinKolarik
Copy link
Contributor

I think you should use the theme, unless you want to provide custom styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants