Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

model save and load does not work #16

Open
adibyte95 opened this issue Jul 7, 2018 · 8 comments
Open

model save and load does not work #16

adibyte95 opened this issue Jul 7, 2018 · 8 comments

Comments

@adibyte95
Copy link

on reloading the model performs very poorly as compared to training

@CarterEllsworth
Copy link

CarterEllsworth commented Jul 20, 2018

Keep in mind that epsilon begins at 1 and decays by 99.5% it's value every 32 time steps as given by batch_size. The policy given by the act method will be random most of the time and can take several episode before getting below 50%.

@adibyte95
Copy link
Author

adibyte95 commented Jul 21, 2018

with a batch size of 128 and the same epsilon decay rate this repo shows impressive result when the model is reloaded. i ran the model several times and it showed good result all the time. The model was trained for less than 1000 episodes

@CarterEllsworth
Copy link

CarterEllsworth commented Jul 21, 2018

It looks like the difference is that keon's code saves and loads the weights whereas your altered code saves and loads the model. I don't have much experience with keras but I would assumed the value of epsilon is reset to 1 when loading the weights and initializing the model

@adibyte95
Copy link
Author

adibyte95 commented Jul 21, 2018

yes i was having a hard time with saving the weights so i switched to saving the model instead, with this the results were much better and i recommend the same . i cannot really comment on your assumption though

@fi000
Copy link

fi000 commented Aug 7, 2018

Adibyte95, Saving model is similar to save weight (because the numbers of nodes are constant). Is there anything more? Why is made your code more accurate than the code of Keon?

@adibyte95
Copy link
Author

I am not sure ....maybe initial weights and not partially trained weights are loaded

@fi000
Copy link

fi000 commented Sep 3, 2018

@keon Is it similar to DDQN? (You mean by DDQN is double or duel DQN?) Saving model is similar to save weight (because the numbers of nodes are constant). Is there anything more? Why is made your code more accurate than the code of Keon?

@WorksWellWithOthers
Copy link

ddqn is double here since there is no dueling implementation in the repo.
The hyperparameters affect the performance of a model greatly.
When comparing implementations please make sure to fix seed samples and hyperparameters.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants