Update disable_erd condition

[lucia-w]

Boolean('false') in js returns true because a non-empty string is considered "truthy" in js.

[lucia-w]

Hey @keonik,
In Node.js, environment variables are persistently stored as string data types. Consequently, irrespective of whether you assign DISABLE_ERD the Boolean value of false, it is ultimately retained in the memory as the string value "false". A potential point of confusion arises when attempting to convert this string value to a Boolean in JavaScript using Boolean('false'). This results in true as JavaScript considers any non-empty string to be "truthy", rather than evaluating its semantic content. I trust this clarifies the intricacies of data type conversion in this context.

When you have a spare moment, could you kindly review this pull request? Your insight and feedback would be greatly appreciated. Thank you for your support.

Cheers,
Lucia

[keonik]

Makes perfect sense! Good catch!

[keonik]

@all-contributors please add @shiralwz for fixing a bug

[allcontributors]

@keonik

I've put up a pull request to add @shiralwz! 🎉

[keonik]

closes #225

[github-actions]

🎉 This PR is included in version 1.10.0-alpha.1 🎉

The release is available on:

• npm package (@alpha dist-tag)
• GitHub release

Your semantic-release bot 📦🚀