Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffusion_projection in ResidualBlock #3

Closed
tebin opened this issue Oct 4, 2021 · 1 comment
Closed

diffusion_projection in ResidualBlock #3

tebin opened this issue Oct 4, 2021 · 1 comment

Comments

@tebin
Copy link

tebin commented Oct 4, 2021

Your implementation has diffusion_projection for every residual block similar to DiffWave, but this is inconsistent with the paper as the original architecture directly adds E_t (output of the step embedding module) to the input before the first convolution layer. Is there a reason behind this change?

@keonlee9420
Copy link
Owner

Hi @tebin , sorry for the late response.
There is no special reason for that. I just borrowed the idea from them and let the model learn in an expected way. But I think the method in the paper might work better somehow, and if you have a room for it, it would be nice if you can try them and share the results for others.

@tebin tebin closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants